Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • xerus xerus
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 41
    • Issues 41
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xerusxerus
  • xerusxerus
  • Issues
  • #256
Closed
Open
Issue created May 29, 2019 by Manuel Marschall@marschallDeveloper

REQUIREs in `uq_ra_adf_iv` are too restrictive

The function xerus::uq::uq_ra_adf_iv in src/xerus/applications/uqADF.cpp requires

_x.order() <=  _measurements.parameterVectors[i].size()

This is too restrictive in the UQ setting. It requires the order of the tensor to be less than the order of the rank-one measurement. This does not take into account the fact that the first mode is reserved for the physical domain.

I propose to change the REQUIRE condition to

_x.order() <=  _measurements.parameterVectors[i].size()+1
Edited Jun 13, 2019 by Philipp Trunschke
Assignee
Assign to
Time tracking