Skip to content

GitLab

xerus
xerus
Closed
Opened by Manuel Marschall@marschall
Report abuse New issue

REQUIREs in `uq_ra_adf_iv` are too restrictive

The function xerus::uq::uq_ra_adf_iv in src/xerus/applications/uqADF.cpp requires

_x.order() <=  _measurements.parameterVectors[i].size()

This is too restrictive in the UQ setting. It requires the order of the tensor to be less than the order of the rank-one measurement. This does not take into account the fact that the first mode is reserved for the physical domain.

I propose to change the REQUIRE condition to

_x.order() <=  _measurements.parameterVectors[i].size()+1
Edited by Philipp Trunschke
To upload designs, you'll need to enable LFS. More information